4396 – 6473 – Remove otel-collector configuration related code#586
Merged
vasconsaurus merged 1 commit intomainfrom Sep 1, 2025
Merged
Conversation
vasconsaurus
changed the title
Contributor
Author
|
The tests failed due to an error in the CodeClimate step. There is a ticket to deal with this. |
caiosba
approved these changes
Sep 1, 2025
vasconsaurus
deleted the
6473-remove-individual-otel-collector-config
branch
vasconsaurus
added a commit
to meedan/check
that referenced
this pull request
Sep 5, 2025
We are using the otel-collector mainly to be able to collect custom metrics from our Rails services. But it is a service that can be used with any of Check's services. Because it is relevant to all of our services we don't want to keep it in individual repos, but keep it in the main Check one. This is only relevant to local development. References: CV2-6473, CV2-4396 Relates to: meedan/pender#586
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Since the otel-collector is relevant to all Check services, we don't want to keep it in individual repos, but keep it in the main Check one.
This is only relevant to local development.
References: CV2-6473, CV2-4396
Relates to: meedan/check#108
How has this been tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can verify the changes. Please describe whether or not you implemented automated tests.
Things to pay attention to during code review
Please describe parts of the change that require extra attention during code review, for example:
Checklist